Incorporate revisions; update lattice #8
Conversation
.gitignore
Outdated
| cpp/ | ||
| json_schema/ | ||
| meta_schema/ |
| performance_map: | ||
| Description: "Performance map" | ||
| Data Type: "{PerformanceMap}" | ||
| Required: "if !performance_points" | ||
| Required: "if !performance_points" |
| fixed_setpoint: | ||
| Data Type: "Boolean" | ||
| Required: False |
There was a problem hiding this comment.
When the setpoint is fixed, where is the value of the setpoint communicated?
| TankNodeSpecification: | ||
| Object Type: "Enumeration" | ||
| Enumerators: | ||
| TOP_NODE: | ||
| Description: "Refers to top tank node." | ||
| Display Text: "Top tank node" | ||
| Notes: "" | ||
|
|
||
| BOTTOM_NODE: | ||
| Description: "Refers to bottom tank node." | ||
| Display Text: "Bottom tank node" | ||
| Notes: "" |
There was a problem hiding this comment.
Where is this used? Is it simulation specific, or something the manufacturer should be able to determine?
There was a problem hiding this comment.
Make "StandbyTemperatureLocation" with "TOP_OF_TANK" and "BOTTOM_OF_TANK" options. (For now)
| resistance_lockout_temperature_hysteresis: # Was hysteresis_temperature_difference in HeatSourceConfiguration | ||
| Description: "Hysteresis for resistance lockout" | ||
| Data Type: Numeric | ||
| Units: "K" | ||
| Required: False | ||
| Notes: | ||
| - "Resistance hysteresis for lockout" |
There was a problem hiding this comment.
Where is this used? Resistance heaters don't "lock out" the same way condensers do, but I can imagine it's used to approximate some kind of behavior?
There was a problem hiding this comment.
I had reached the mistaken conclusion that this was needed, but after further testing, it seems that it does not affect any regressions. But it must have seemed necessary at some point, because values are entered for most models with resistance heat sources.
Incorporates several changes from revisions PR.